Skip to content

Deny return-position impl Trait in traits for object safety #101681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

Deny return-position impl Trait in traits for object safety #101681

merged 1 commit into from
Sep 12, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #101667

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 11, 2022
@rust-highfive
Copy link
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2022
@lcnr
Copy link
Contributor

lcnr commented Sep 12, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2022

📌 Commit 89b6488 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2022
@bors
Auto merge of rust-lang#101716 - Dylan-DPC:rollup-ayvh6nd, r=Dylan-DPC
7f115e3 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#100293 (Add inline-llvm option for disabling/enabling LLVM inlining)
 - rust-lang#100767 (Remove manual <[u8]>::escape_ascii)
 - rust-lang#101668 (Suggest pub instead of public for const type item)
 - rust-lang#101671 (Fix naming format of IEEE 754 standard)
 - rust-lang#101676 (Check that the types in return position `impl Trait` in traits are well-formed)
 - rust-lang#101681 (Deny return-position `impl Trait` in traits for object safety)
 - rust-lang#101693 (Update browser UI test 0 10)
 - rust-lang#101701 (Rustdoc-Json: Add tests for trait impls.)
 - rust-lang#101706 (rustdoc: remove no-op `#search`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6bacb6f into rust-lang:master Sep 12, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 12, 2022
@compiler-errors compiler-errors deleted the rpitit-obj-safety branch November 2, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

ICE Object safety violation when creating RPITIT trait object
5 participants
@compiler-errors @rust-highfive @lcnr @bors @rustbot